Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cast to decimal wrong sign #9300

Merged
merged 7 commits into from
Aug 9, 2024
Merged

fix cast to decimal wrong sign #9300

merged 7 commits into from
Aug 9, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Aug 8, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9301
ref pingcap/tidb#53892

Problem Summary:

cast -0.741(decimal(11, 4)) to decimal(10, 0)

intput Decimal32
    value: -7410
    scale: 4

cast calc process: 
1. calc new value: -7410 / scale_mul(10000) = 0
2. 7410 % 10000 > 5000, so need to round
3. old value is neg, so result should be 0-1 = -1.
    (bug here, should check old value's sign instead new value's sign, because new value canbe zero)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
fix cast to decimal(10, 0)
cdfe780 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
@guo-shaoge
refine case
48d0390 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix case
2dfce49 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
@guo-shaoge guo-shaoge changed the title fix cast to decimal(10, 0) wrong sign fix cast to decimal wrong sign Aug 8, 2024
yibin87
yibin87 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 8, 2024
@guo-shaoge guo-shaoge requested a review from gengliqi August 9, 2024 02:33
gengliqi
gengliqi approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-08 06:13:40.505025193 +0000 UTC m=+505350.372124274: ☑️ agreed by yibin87.
  • 2024-08-09 04:52:26.295526704 +0000 UTC m=+586876.162625787: ☑️ agreed by gengliqi.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 0861ee6 into pingcap:master Aug 9, 2024
5 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 26, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Aug 26, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9356.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9357.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9358.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9359.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 26, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#9300
16e6bd2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9360.

@JaySon-Huang JaySon-Huang deleted the cast_decimal_bug_fix branch August 26, 2024 05:12
ti-chi-bot bot added a commit that referenced this pull request Sep 3, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix cast to decimal wrong sign (#9300) (#9359)
5c5a848 
close #9301

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix cast to decimal wrong sign (#9300) (#9358)
d86755d 
close #9301

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix cast to decimal wrong sign (#9300) (#9357)
19a0de7 
close #9301

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Sep 27, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix cast to decimal wrong sign (#9300) (#9356)
08595f4 
close #9301

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 11, 2024
@ti-chi-bot @guo-shaoge @ti-chi-bot
fix cast to decimal wrong sign (#9300) (#9360)
d0d987f 
close #9301

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi approved these changes

@yibin87 yibin87 yibin87 approved these changes

@xzhangxian1008 xzhangxian1008 Awaiting requested review from xzhangxian1008

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiflash cast to decimal(10, 0) wrong result
4 participants
@guo-shaoge @ti-chi-bot @yibin87 @gengliqi